From 4c5489915e62b5b23851e9f79466a28bc30d15cf Mon Sep 17 00:00:00 2001 From: Offending Commit Date: Tue, 12 May 2026 10:46:35 -0500 Subject: [PATCH] ci: move desktop cargo check out of github actions --- .github/workflows/ci.yml | 33 +-------------------------------- AGENTS.md | 16 ++++++++++++++++ CLAUDE.md | 2 ++ 3 files changed, 19 insertions(+), 32 deletions(-) create mode 100644 AGENTS.md diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1278837..08365db 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,40 +17,9 @@ jobs: - run: make ci-web - cargo-check: - name: Rust compile check - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Cache apt packages - uses: actions/cache@v4 - with: - path: ~/apt-cache - key: ${{ runner.os }}-apt-tauri-${{ hashFiles('.github/workflows/ci.yml') }} - restore-keys: | - ${{ runner.os }}-apt-tauri- - - - name: Install Linux dependencies - run: | - mkdir -p ~/apt-cache && chmod -R a+rw ~/apt-cache - sudo apt-get update - sudo apt-get install -y --no-install-recommends -o dir::cache::archives="$HOME/apt-cache" libwebkit2gtk-4.1-dev libappindicator3-dev librsvg2-dev patchelf - sudo chmod -R a+rw ~/apt-cache - - - uses: dtolnay/rust-toolchain@stable - - - uses: Swatinem/rust-cache@v2 - with: - workspaces: packages/desktop/src-tauri -> target - - - uses: ./.github/actions/setup - - - run: make ci-desktop - release: name: Release - needs: [check, cargo-check] + needs: [check] if: github.event_name == 'push' && github.ref == 'refs/heads/main' runs-on: ubuntu-latest permissions: diff --git a/AGENTS.md b/AGENTS.md new file mode 100644 index 0000000..72ec0fd --- /dev/null +++ b/AGENTS.md @@ -0,0 +1,16 @@ +# openconcho Agent Notes + +## CI policy + +- PR CI only runs the web checks. +- Rust/Tauri compile-check is local-only for now because the Linux dependency setup on GitHub Actions is too slow for routine PR validation. + +## Required local preflight + +- Before pushing any change under `packages/desktop/**` or `packages/desktop/src-tauri/**`, run: + - `pnpm --filter @openconcho/desktop cargo-check` + +## Useful commands + +- `make ci-web` — matches current PR CI +- `pnpm --filter @openconcho/desktop cargo-check` — local desktop compile check diff --git a/CLAUDE.md b/CLAUDE.md index d647c4c..0ea8d5f 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -17,6 +17,7 @@ Frontend UI for self-hosted Honcho instances — browse memories, peers, session | `make test` | Vitest (unit + integration), excludes `e2e/` | | `make test-e2e` | Playwright e2e (uncached) | | `make check` | lint + typecheck + test | +| `pnpm --filter @openconcho/desktop cargo-check` | Local Rust/Tauri compile check before pushing desktop changes | | `pnpm --filter @openconcho/web generate:api` | Regen `src/api/schema.d.ts` from `openapi.json` | ## Structure @@ -58,3 +59,4 @@ Read `docs/architecture.md` for component overview, data flow, and design decisi - **Conventional commits enforced** — commitlint runs in husky `commit-msg`; body lines must be ≤100 chars - **Releases via semantic-release** — `.releaserc.json`; commits land on `main`, no manual version bumps - **GitHub account** — push under `offendingcommit` (`gh auth switch` if needed) +- **Desktop preflight is local** — Rust/Tauri compile-check no longer runs in PR CI; run `pnpm --filter @openconcho/desktop cargo-check` before pushing any `packages/desktop/**` or `packages/desktop/src-tauri/**` change