fix: restrict docker commands for ai-worker user

Remove ai-worker from docker group and enforce sudo whitelist.

SECURITY: Being in the docker group gives unrestricted access to the
Docker daemon socket (/var/run/docker.sock), allowing any docker command:
docker exec, docker cp, docker run -v /:/host, docker commit, etc.

Changes:
- Remove extraGroups = ["docker"] from ai-worker user definition
- Add comprehensive sudo NOPASSWD whitelist for safe docker subcommands
  ALLOWED: ps, inspect, logs, images, info, version, stats, start, stop,
  restart, rm, rmi, wait, pull, build, run, compose, system,
  network ls, volume ls
  BLOCKED (implicitly): exec, cp, commit, diff, export, import, load,
  save, attach, push, tag, create, plugin, network create, volume create
- Update ai-worker-restricted.nix module to reflect new approach
- Update README-ai-worker.md with new security model and examples

All docker commands must now be prefixed with sudo.
The Hermes agent's host_run tool needs to be updated to prepend sudo.

modules/nixos/security/README-ai-worker.md

@@ -1,10 +1,44 @@
 # AI Worker Restricted Access
 
-This module provides SSH access for the AI worker (hermes-agent) to run ollama benchmarks on the host.
+This module provides SSH access for the AI worker (hermes-agent) to run docker commands on the host.
 
 ## Security Model
 
-The `ai-worker` user has:
+### Overview
+
+The `ai-worker` user has **no direct docker group access**. All docker commands must go through `sudo`, and only specific subcommands are whitelisted:
+
+- **Container lifecycle**: `docker ps`, `docker inspect`, `docker logs`, `docker images`, `docker info`, `docker version`, `docker stats`
+- **Control**: `docker start`, `docker stop`, `docker restart`, `docker rm`, `docker rmi`, `docker wait`
+- **Image management**: `docker pull`, `docker build`, `docker run`, `docker compose`
+- **Disk cleanup**: `docker system`
+- **Network/Volume**: `docker network ls`, `docker volume ls` (read-only)
+
+### EXPLICITLY BLOCKED (not in sudo whitelist)
+
+| Command | Risk | Result |
+|---------|------|--------|
+| `docker exec` | Execute arbitrary commands inside containers (FILE MODIFICATION) | Blocked by sudo |
+| `docker cp` | Copy files between containers and host | Blocked by sudo |
+| `docker commit` | Create images from running containers (data exfil) | Blocked by sudo |
+| `docker diff` | Inspect filesystem changes | Blocked by sudo |
+| `docker export` | Export container filesystem | Blocked by sudo |
+| `docker import` | Import filesystem archives | Blocked by sudo |
+| `docker load` | Load docker images | Blocked by sudo |
+| `docker save` | Save docker images to tar | Blocked by sudo |
+| `docker attach` | Interactive access to containers | Blocked by sudo |
+| `docker push` | Push images to registries | Blocked by sudo |
+| `docker tag` | Rename images | Blocked by sudo |
+
+### Why This Approach?
+
+Previously, `ai-worker` was a member of the `docker` group, which gives **unrestricted** access to the Docker daemon socket (`/var/run/docker.sock`). Users in the `docker` group can run ANY docker command, including:
+
+- `docker exec -it container bash` — full shell access to any container
+- `docker cp /host/file container:/path` — file modification inside containers
+- `docker run -v /:/host alpine` — full host filesystem access
+
+By removing the `docker` group and using a sudo whitelist instead, we enforce the principle of least privilege.
 
 ### Filesystem Access
 - **Home directory**: `/home/ai-worker` (standard user home)
@@ -12,51 +46,33 @@ The `ai-worker` user has:
 - **Cannot access**: Any files outside standard system paths
 
 ### Sudo Access
-- **NONE**: ai-worker has no sudo privileges
+- **Restricted**: ai-worker has `NOPASSWD` access only to whitelisted commands
 - Cannot run `nh`, `nixos-rebuild`, `nixpkgs-fmt`, or `nix` with elevated permissions
 
-### Docker Access
+## Workflow: SSH + Restricted Docker
-- Member of `docker` group - can run `docker` and `docker exec` commands
-- Primary use: `docker exec ollama ollama ...` for benchmarking
-- Can run `docker exec --privileged ollama rocm-smi ...` for VRAM monitoring
 
-## Workflow: SSH + Docker Benchmarking
+All docker commands must be prefixed with `sudo`:
-
-The AI worker connects from the Hermes container to the host via SSH, runs ollama benchmarks, then returns to save results.
-
-### Example Workflow
 
 ```bash
 # From Hermes container, SSH to host
 ssh -i /path/to/ssh/key ai-worker@host.docker.internal
 
-# On host, run ollama benchmarks via docker
+# Check container status (works)
-docker exec ollama ollama pull devstral-small-2:24b
+sudo docker ps
 
-# Create test modelfile
+# Restart a container (works)
-docker exec ollama bash -c 'cat <<EOF > /root/.ollama/test.modelfile
+sudo docker restart ollama
-FROM devstral-small-2:24b
-PARAMETER num_ctx 65536
-PARAMETER num_gpu 99
-PARAMETER flash_attn true
-EOF'
 
-# Create and test model
+# Run benchmark (works - docker run is allowed)
-docker exec ollama ollama create test-model -f /root/.ollama/test.modelfile
+sudo docker run --rm alpine echo "test"
-docker exec ollama ollama run test-model "Write a Python async function"
 
-# Check VRAM usage
+# ANY of these will FAIL (not in whitelist):
-docker exec --privileged ollama rocm-smi --showmeminfo vram
+sudo docker exec ollama ollama list          # FAILS - docker exec blocked
+sudo docker cp file.txt container:/path/     # FAILS - docker cp blocked
+sudo docker commit container new-image       # FAILS - docker commit blocked
 
-# Cleanup
+# For ollama operations, use the HTTP API instead of docker exec:
-docker exec ollama ollama rm test-model
+curl http://ollama:11434/api/tags
-
-# Exit SSH, return to Hermes container
-exit
-
-# Save results in Hermes container
-# /opt/data/ai-optimizer/state.json
-# /opt/data/ai-optimizer/results.csv
 ```
 
 ## SSH Access
@@ -74,25 +90,30 @@ Check ai-worker permissions:
 ```bash
 # On the host, as root or gortium:
 sudo -u ai-worker sudo -l
-# Should show: no sudo access
+# Should show the whitelisted commands only (no docker exec/cp/commit)
 
-# Check docker group membership
+# Verify NOT in docker group
 groups ai-worker
-# Should show: ai-worker docker
+# Should show: ai-worker (NO docker group)
 ```
 
 ## Troubleshooting
 
-If ai-worker cannot run docker commands:
+If docker commands fail:
+
 ```bash
-# Check docker group membership
+# Check sudo permissions
+sudo -u ai-worker sudo -l | grep docker
+
+# Verify group membership
 groups ai-worker
 
-# Verify ollama container is running
+# Test allowed command
-docker ps | grep ollama
+sudo -u ai-worker sudo docker ps
 
-# Test docker access
+# Test blocked command (should fail)
-sudo -u ai-worker docker exec ollama ollama list
+sudo -u ai-worker sudo docker exec ollama ollama list
+# Expected: "Sorry, user ai-worker is not allowed to execute"
 ```
 
 If SSH connection fails:

modules/nixos/security/ai-worker-restricted.nix

@@ -6,12 +6,19 @@ with lib;
   options.services.aiWorkerAccess = mkOption {
     type = types.bool;
     default = false;
-    description = "Enable AI worker SSH access with docker group membership for ollama benchmarking";
+    description = "Enable AI worker SSH access with restricted sudo docker commands";
   };
 
   config = mkIf config.services.aiWorkerAccess {
-    # ai-worker is member of docker group - can run docker commands via SSH
+    # SECURITY: ai-worker is NOT added to docker group.
-    # No bind mounts, no sudo access - docker-only for ollama benchmarking
+    # Docker access is granted via sudo whitelist in users/ai-worker.nix.
-    users.groups.docker.members = [ "ai-worker" ];
+    # This prevents unrestricted docker daemon access (docker exec, cp, commit, etc.)
+    # Only specific docker subcommands are allowed via sudo NOPASSWD rules.
+    
+    # The old approach (docker group membership) has been removed because:
+    # - Docker group gives UNRESTRICTED access to the docker daemon socket
+    # - No way to limit which docker subcommands a docker group member can run
+    # - Allowed: docker exec, docker cp, docker run -v /:/host, etc.
+    # users.groups.docker.members = [ "ai-worker" ];  // REMOVED
   };
 }

users/ai-worker.nix

@@ -4,7 +4,9 @@
     group = "ai-worker";
     home = "/home/ai-worker";
     createHome = true;
-    extraGroups = [ "docker" ];
+    # SECURITY: ai-worker is NOT in the docker group.
+    # Docker access is restricted via sudo whitelist — only specific subcommands allowed.
+    # extraGroups = [ "docker" ]; — REMOVED: docker group gives unrestricted docker daemon access
     shell = pkgs.bashInteractive;
     openssh.authorizedKeys.keys = [
       keys.users.ai-worker.main
@@ -17,19 +19,134 @@
   # Enable restricted AI worker SSH access for ollama benchmarking
   # SECURITY: ai-worker can only:
   #   - SSH into host from Hermes container
-  #   - Run docker commands (docker exec ollama ...) via docker group
+  #   - Run docker commands via sudo (whitelist below — no exec/cp/commit)
   #   - Run specific security audit commands
   #   - NO access to infra repo (no bind mount)
-  #   - NO sudo access (no nh, nixos-rebuild, nixpkgs-fmt, nix)
+  #   - NO nix/nixos-rebuild/nh commands
-  # WORKFLOW: SSH from Hermes container, run docker benchmarks, return and save results to /opt/data/ai-optimizer/
+  # WORKFLOW: SSH from Hermes container, run docker commands via sudo, return and save results
   services.aiWorkerAccess = true;
-  
+
-  # Restricted sudo for ai-worker - security checks only
+  # Restricted sudo for ai-worker
+  # IMPORTANT: ai-worker is NOT in docker group. All docker access goes through sudo.
+  # Only the subcommands listed below are allowed — everything else is denied.
+  # This prevents: docker exec, docker cp, docker commit, and other file-modifying operations.
   security.sudo.extraRules = [
     {
       users = [ "ai-worker" ];
       commands = [
-        # Firewall checks
+        # === Docker commands: lifecycle management (NO file modification) ===
+        # ps/inspect/logs — read-only status checks
+        {
+          command = "/run/current-system/sw/bin/docker ps";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker inspect *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker logs *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker images";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker info";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker version";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker stats *";
+          options = [ "NOPASSWD" ];
+        }
+
+        # start/stop/restart — container lifecycle
+        {
+          command = "/run/current-system/sw/bin/docker start *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker stop *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker restart *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker rm *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker rmi *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker wait *";
+          options = [ "NOPASSWD" ];
+        }
+
+        # pull/build/run — image management and container creation
+        {
+          command = "/run/current-system/sw/bin/docker pull *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker build *";
+          options = [ "NOPASSWD" ];
+        }
+        {
+          command = "/run/current-system/sw/bin/docker run *";
+          options = [ "NOPASSWD" ];
+        }
+
+        # compose — orchestration
+        {
+          command = "/run/current-system/sw/bin/docker compose *";
+          options = [ "NOPASSWD" ];
+        }
+
+        # system — disk cleanup
+        {
+          command = "/run/current-system/sw/bin/docker system *";
+          options = [ "NOPASSWD" ];
+        }
+
+        # network — list only (create/modify not needed)
+        {
+          command = "/run/current-system/sw/bin/docker network ls";
+          options = [ "NOPASSWD" ];
+        }
+
+        # volume — list only (create/modify not needed)
+        {
+          command = "/run/current-system/sw/bin/docker volume ls";
+          options = [ "NOPASSWD" ];
+        }
+
+        # === EXPLICITLY DENIED docker commands (not in whitelist — sudo rejects them) ===
+        # docker exec     — executes arbitrary commands inside running containers (FILE MODIFICATION)
+        # docker cp       — copies files between containers and host (FILE ACCESS)
+        # docker commit   — creates images from running containers (DATA EXFIL)
+        # docker diff     — inspects filesystem changes (INFO LEAK)
+        # docker export   — exports container filesystem (DATA EXFIL)
+        # docker import   — imports filesystem archives
+        # docker load     — loads docker images
+        # docker save     — saves docker images to tar (DATA EXFIL)
+        # docker attach   — attaches to running containers (INTERACTIVE ACCESS)
+        # docker push     — pushes images to registries (DATA EXFIL)
+        # docker tag      — renames images
+        # docker create   — creates containers (use 'docker run' instead)
+        # docker plugin   — manages plugins
+        # docker network create/rm — network management
+        # docker volume create/rm  — volume management
+
+        # === Firewall checks ===
         {
           command = "/run/wrappers/bin/sudo iptables -L -n -v";
           options = [ "NOPASSWD" ];
@@ -38,7 +155,8 @@
           command = "/run/wrappers/bin/sudo iptables -S";
           options = [ "NOPASSWD" ];
         }
-        # Fail2ban status
+
+        # === Fail2ban status ===
         {
           command = "/run/current-system/sw/bin/fail2ban-client status";
           options = [ "NOPASSWD" ];
@@ -51,7 +169,8 @@
           command = "/run/current-system/sw/bin/fail2ban-client get * banned";
           options = [ "NOPASSWD" ];
         }
-        # Log inspection
+
+        # === Log inspection ===
         {
           command = "/run/current-system/sw/bin/journalctl -t kernel -n 100";
           options = [ "NOPASSWD" ];
@@ -64,21 +183,14 @@
           command = "/run/current-system/sw/bin/journalctl -u firewall -n 50";
           options = [ "NOPASSWD" ];
         }
-        # SSH config verification
+
+        # === SSH config verification ===
         {
           command = "/run/current-system/sw/bin/sshd -T";
           options = [ "NOPASSWD" ];
         }
-        # Docker service checks
+
-        {
+        # === Network diagnostics ===
-          command = "/run/current-system/sw/bin/docker ps";
-          options = [ "NOPASSWD" ];
-        }
-        {
-          command = "/run/current-system/sw/bin/docker inspect *";
-          options = [ "NOPASSWD" ];
-        }
-        # Network diagnostics
         {
           command = "/run/current-system/sw/bin/ss -tlnp";
           options = [ "NOPASSWD" ];